search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

No data returned at all #139

Open sebelk opened 5 years ago

sebelk commented 5 years ago

Hi, I'm using soccer-cli (0.1.0.0) and it returns no data, for example:

$ soccer --players --team=BM
No data for the team. Please check the team code.

No standings, no players, nothing at all. Is this project alive?

The python version is 3.6.7

Thanks in advance

Saturn commented 5 years ago

You should still be able to get some data.

Although, the data source changed its API which is why if you try to get standings for the English Premier League for example, you will get data from last season (2017/2018).

The code would need to be adjusted to support the new API. As well as potentially updated to support the various access tiers which include support for different leagues/statistics etc.

https://www.football-data.org/documentation/api

tiktuk commented 5 years ago

I don't get any data returned either.

$ soccer --standings --league=EPL
No standings availble for EPL.
Saturn commented 5 years ago

Okay, it seems like the old v1 api url no longer returns the "old" data either.

The new api is structurally a little different so it isn't totally simple to change over.

I will have a closer look soon.

Thanks,

Saturn commented 5 years ago

@tiktuk @sebelk I have updated most of the commands to work with the new version of the api. https://github.com/architv/soccer-cli/commit/7fdabcf8abb0b4a33c9bf98e6ba5e16a1cfde3d1

Are you able to get data back now?

tiktuk commented 5 years ago

Yes, thanks, it looks good ☺️ !

dfrt82 commented 5 years ago

Okay, it seems like the old v1 api url no longer returns the "old" data either.

Yes that's correct. v1 was shut down last week, but it was announced in July and December that it will be shut down to the end of 2018...

The new api is structurally a little different so it isn't totally simple to change over.

Yes, but just a little :-) Major enhancement are the fixed league codes, so now there's no need to touch the code for the new season any more.

Saturn commented 5 years ago

Thank you @dfrt82