search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

Fixed bug when retrieving players of a team #147

Closed mchac1 closed 4 years ago

mchac1 commented 4 years ago

Fixed bug when retrieving players of a team. When no shirt number is assigned to a player in the team, the sort errors. Removed the sort and expanded the Number column from 4 chars to 6 so it can contain the word "None" for those cases. Also changed the format string to be able to convert shirtnumber value to a string. This way both numbers and the word "None" can display correctly in output.

Saturn commented 4 years ago

Thanks @mchac1 👍

Quick tip: Remember to add an empty line between the first line of commit message and the rest. That way it will wrap a bit more nicely when displaying in Github or elsewhere.

mchac1 commented 4 years ago

Thanks for the tip @Saturn! I will do that next time for sure.