search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

Fix module bin install issue #16 #23

Closed Saturn closed 8 years ago

Saturn commented 8 years ago

Fix architv/soccer-cli#16

Previously the setup script places 'main.py', 'leagueids.py' etc into the /bin folder along with the 'soccer' script.

This was not desired as it meant not only was the soccer command available via the command line (nice!) but typing main.py or leagueids.py would also run the python scripts...

This change means that only soccer gets placed in the /bin folder.

Before not_working

After working

Saturn commented 8 years ago

It might be a better idea to put the python modules into a separate directory package.

And then just reference the package within the setup.py file.

I have done this here Saturn/soccer-cli@b84e3952cdda890978b2058b34b4f8b65da0cc21

The advantage would be if there was another module added in the future then the setup.py would not have to be modified. At least that is my basic understanding :smile:

architv commented 8 years ago

Cool @Saturn ! I have merged it. I will create a separate directory for the python modules.

Saturn commented 8 years ago

:+1: