search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

CL playoff color spot #34

Closed ueg1990 closed 8 years ago

ueg1990 commented 8 years ago

Hey now that we got EL spot, we should do a separate shade for the fourth spot :stuck_out_tongue:

like here: http://www.espnfc.com/barclays-premier-league/23/table

architv commented 8 years ago

Currently the top four spots are green and bold. Would making the fourth spot (or the playoff spot) only green and not bold do it?

ueg1990 commented 8 years ago

looks good to me. @Saturn ?

architv commented 8 years ago

@Saturn @carlosvargas any suggestions?

Saturn commented 8 years ago

Would there have to be slightly more detailed properties?

So we can differentiate group stage teams and 3rd round qualifying etc. It is kind of messy right now with how it checks the league properties and applies the correct colours.

ueg1990 commented 8 years ago

its not a big deal now...we can close it for now and deal with it later or we can wait till one of us comes with a better solution. Most probably we will still have to update leagueproperties.py and update the lists again. If we end up doing that, we should definitely then introduce namedtuples for easier access

architv commented 8 years ago

Closing this for now.