search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

Import the live API to version control #6

Closed ctlaltdefeat closed 8 years ago

ctlaltdefeat commented 8 years ago

Instead of

LIVE_API = 'http://soccer-cli.appspot.com/'

have the actual code

architv commented 8 years ago

Sorry, I didn't get you. Could you please tell a bit more?

Saturn commented 8 years ago

Probably means have the code running http://soccer-cli.appspot.com/ included. Presumably it uses some scraping or some other resource to get the live score data?

architv commented 8 years ago

Yes, I built that resource to scrape live scores. Since, it is not part of the business logic of the application, I separated it out. Is it anyway better to include that code here?

ueg1990 commented 8 years ago

I think you should have it in your main.py like you did with the following: BASE_URL = 'http://api.football-data.org/alpha/'

ctlaltdefeat commented 8 years ago

Sorry, I did in fact mean to have the code running the live API included

architv commented 8 years ago

I am not sure if that is necessary. If need be I'll make separate repo an push that code here.