Add team name to team code list

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.

MIT License

1.09k stars 221 forks source link

Add team name to team code list #71

Closed thurask closed 8 years ago

thurask commented 8 years ago

Fix #69, again.

$ soccer --list
ACM: AC Milan
AFC: Arsenal FC
AFCB: AFC Bournemouth
ATM: Club Atlético de Madrid
AVFC: Aston Villa FC
B04: Bayer Leverkusen
BIL: Athletic Club
BM: FC Bayern München
BMG: Bor. Mönchengladbach
BOR: FC Girondins de Bordeaux
BSC: Hertha BSC
BVB: Borussia Dortmund
CFC: Chelsea FC
etc.

It's not as intuitive as entering a team name and getting the exact code, but with this we don't need to deal with synonyms, special characters, abbreviations, etc.

Saturn commented 8 years ago

Would it be a good idea to have the list break down the teams in league sections instead of alphabetically?

Of course this would mean reworking the teamcodes and teamnames since they don't hold information about which league they are in. And many teams do not have a teamcode at all which is a problem.

So for now this is useful.

thurask commented 8 years ago

Rewriting the JSON to hold code, league, synonyms etc would make things easier but would require changing a lot of things.

ueg1990 commented 8 years ago

Rewriting/restructuring the JSON would definitely need alot of things. But are we now not having the individual team lookup?

ueg1990 commented 8 years ago

also one more suggestion...if all the JSON data will be re-written, we should keep them in their own folder (like data).

architv commented 8 years ago

The teamcode data is currently broken and there are lot of teams which have null as their team code. We'll have to rewrite the data sometime. For now, I think this is a good solution.