search

archived-codacy / node-codacy-coverage

Code Coverage reporter for Codacy
MIT License
63 stars 45 forks source link

Set exit code to non-zero value on error, fix #42 #47

Closed bobisjan closed 6 years ago

rtfpessoa commented 6 years ago

Hi @bobisjan, thanks for your contribution. Seems like since you set the exit code the tests are exiting with it and failing. Can you take a look? CircleCI should start in the next commit, but due to configurations it did not start in this one.

bobisjan commented 6 years ago

Hi @rtfpessoa,

it seems that all 39 tests are passing, the problem is with 2 vulnerabilities found (moment and tough-cookie), I think it should be handled by #46, then this can be merged.

I used yarn test locally, so I did not find this error until used npm test. Sorry, it prints error with yarn test too, but the problem is same.

rtfpessoa commented 6 years ago

@bobisjan you are right. I missed that part. The other PR is stale for a while need to check it with Joi 12 and see if it works.

rtfpessoa commented 6 years ago

@bobisjan please rebase with master to bring the fixes for the versions.

bobisjan commented 6 years ago

@rtfpessoa done.

rtfpessoa commented 6 years ago

Will be released as version 2.1.0