Fix tests (thanks @DavidTPate)

archived-codacy / node-codacy-coverage

Code Coverage reporter for Codacy

MIT License

63 stars 45 forks source link

Fix tests (thanks @DavidTPate) #5

Closed rtfpessoa closed 9 years ago

rtfpessoa commented 9 years ago

skip comparison when commit is pr

DavidTPate commented 9 years ago

Looks like the build still failed, but Travis is currently under maintenance. I'll take a look tomorrow and try to see what's going on.

DavidTPate commented 9 years ago

As I mentioned in the issue there reason why it didn't work is that the Travis documentation had some more detail on what the environment variable we are using would be. Here's the relevant part: TRAVIS_PULL_REQUEST: The pull request number if the current job is a pull request, "false" if it's not a pull request. I went ahead and changed it to account for this and everything's working fine :)

rtfpessoa commented 9 years ago

@DavidTPate good catch. Thank you.