search

archived-codacy / python-codacy-coverage

DEPRECATED Python coverage reporter for Codacy
BSD 3-Clause "New" or "Revised" License
45 stars 38 forks source link

fix file_exists #38

Closed dhensen closed 6 years ago

dhensen commented 6 years ago

When having a filename=foo/bar/baz it would never be matched in files produced by os.walk.

I just used os.path.exists, tests pass.

There is a an issue with py350 in tox config though.

IceflowRE commented 6 years ago

See #36

dhensen commented 6 years ago

@IceflowRE Wow I fixed the same thing :astonished: I've been wanting to fix this for a while, but did not have time. I did not check outstanding PR's before starting this an hour ago. What a coincidence that 2 people fix the same thing on the same day... your PR covers more stuff though, good work :+1:

dhensen commented 6 years ago

@IceflowRE did you run tests locally? What python version do you have? I ask this because I had issues with the unicode keyword not being in python3.

IceflowRE commented 6 years ago

I run tests with nose2 so i cant say much about tox. And no i run the tests via CI and only for python 3.6/(3.7), since i need the latest features of python ^^

dhensen commented 6 years ago

Good to know. I guess then there is more going on on that CI server, because locally I could in no way make tests pass without that unicode keyword fix. I run python 3.6.3 to be exact.

rtfpessoa commented 6 years ago

Sorry for the delay. Fixed by #36. Let me know if I missed something.