archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

Problem: Various deprecated Javascript functions in qa/1.x Dashboard #1255

Open ross-spencer opened 4 years ago

ross-spencer commented 4 years ago

Expected behaviour

We should move away from deprecated functions where possible and we shouldn't see warnings in the web-browsers we're testing against.

Current behaviour

Monitoring the various console outputs this morning, I can see three from just the basic workflow:

  1. Starting/approving:

    dashboard.js:16149 AlertController is now deprecated. Use UibAlertController instead.
    (anonymous) @   dashboard.js:16149
    (anonymous) @   dashboard.js:84512
    invoke  @   dashboard.js:6721
    $controllerInit @   dashboard.js:12542
    nodeLinkFn  @   dashboard.js:11419
    (anonymous) @   dashboard.js:11836
    processQueue    @   dashboard.js:18646
    (anonymous) @   dashboard.js:18662
    $eval   @   dashboard.js:19944
    $digest @   dashboard.js:19758
    $apply  @   dashboard.js:20052
    (anonymous) @   dashboard.js:28547
    dispatch    @   jquery.js:4
    r.handle    @   jquery.js:4
  2. Starting/approving a transfer also:

    dashboard.js:16149 alert is now deprecated. Use uib-alert instead.
    (anonymous) @   dashboard.js:16149
    link    @   dashboard.js:84517
    (anonymous) @   dashboard.js:3209
    (anonymous) @   dashboard.js:12096
    invokeLinkFn    @   dashboard.js:12102
    nodeLinkFn  @   dashboard.js:11501
    (anonymous) @   dashboard.js:11836
    processQueue    @   dashboard.js:18646
    (anonymous) @   dashboard.js:18662
    $eval   @   dashboard.js:19944
    $digest @   dashboard.js:19758
    $apply  @   dashboard.js:20052
    (anonymous) @   dashboard.js:28547
    dispatch    @   jquery.js:4
    r.handle    @   jquery.js:4
  3. Selecting a storage location on the ingest tab:

    jquery.js:5 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
    send    @   jquery.js:5
    ajax    @   jquery.js:5
    executeCommand  @   ingest.js:269
    action  @   ingest.js:428
    dispatch    @   jquery.js:4
    r.handle

Steps to reproduce

Open the developer console in Chrome (in my case) and then monitor the various UI activities you perform for these responses from the client.

Your environment (version of Archivematica, operating system, other relevant details)

Archivematica qa/1.x. Running Chrome: Version 83.0.4103.


For Artefactual use:

Before you close this issue, you must check off the following:

ross-spencer commented 4 years ago

Related to https://github.com/artefactual/archivematica/issues/872