archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

Problem: full re-ingest with unstored DIP breaks at "Generate DIP" #1414

Open jrwdunham opened 6 years ago

jrwdunham commented 6 years ago

Steps to re-create

  1. Create an AIP with normalization for preservation and access.
  2. Store the resulting AIP.
  3. Choose not to upload the DIP; choose to store it but do not provide a DIP storage location.
  4. Initiate a full re-ingest on the AIP.
  5. Observe that micro-service "Prepare DIP: Generate DIP" has failed. The stderr is as below:

mv: cannot move ‘/var/archivematica/sharedDirectory/watchedDirectories/workFlowDecisions/metadataReminder/hierarchy_with_empty_dir_1508357212-9d46b1e1-af5b-4675-8cb3-acc177fddd15/DIP’ to ‘/var/archivematica/sharedDirectory/watchedDirectories/uploadDIP/hierarchy_with_empty_dir_1508357212-9d46b1e1-af5b-4675-8cb3-acc177fddd15/DIP’: Directory not empty

Presumably the unstored DIP created initially is still present and is causing this issue.

jhsimpson commented 6 years ago

This is a problem caused by the fact that the DIP generation/upload/store workflow splits from the AIP generation workflow. The inverse of this issue is that it is possible to successfully store a DIP without having stored an AIP, a situation that probably should not be allowed.

I think when an aip reingest is requested, if there are any un-answered user input questions (upload dip, store dip, store dip location, or any others) then the aip reingest request should fail, indicating that processing of the original aip is not complete.

I don't think this should be considered in scope for the 1.7.0 release - the workaround is to answer all user inputs before attempting aip reingest.