archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

problem: Manual Normalization failed with normalization.csv due to option used in fileOperations.py during ingest step #1556

Open rguedj18 opened 2 years ago

rguedj18 commented 2 years ago

Expected behaviour Process manual normalization by reading normalization.csv files

Current behaviour Task "Move access files to DIP" fails

error message: "Error reading /var/archivematica/sharedDirectory/currentlyProcessing/kerhen_manulaNormalization-nonDiacritic-test-04-a8333caa-106c-464a-9dcb-d8bcafd83d95/objects/manualNormalization/normalization.csv on line 0"

Steps to reproduce

We have solved the problem by changing the option used by the parser

Manual Normalization fails with AM 1.13.2. due to an option used to parse normalization.csv here: archivematica/fileOperations.py at stable/1.13.x · artefactual/archivematica (github.com) line 347 use universal newline mode to support unusual newlines, like \r with open(csv_path, "rbU") as csv_file: reader = csv.reader(csv_file)

instead of use universal newline mode to support unusual newlines, like \r with open(csv_path, "rU") as csv_file: reader = csv.reader(csv_file)

The binary option failed. It has been changed to another part of the code when AM parses metadata.csv : archivematica/archivematicaCreateMETSMetadataCSV.py at stable/1.13.x · artefactual/archivematica (github.com) line 101

use universal newline mode to support unusual newlines, like \r with open(metadataCSVFilePath, "rU") as f: reader = csv.reader(f)

here the option b has been removed from the AM 1.12 archivematica/archivematicaCreateMETSMetadataCSV.py at stable/1.12.x · artefactual/archivematica (github.com) line 100

use universal newline mode to support unusual newlines, like \r with open(metadataCSVFilePath, "rbU") as f: reader = csv.reader(f)

Your environment (version of Archivematica, operating system, other relevant details) AM 1.13.2 4.15.0-175-generic Distributor ID: Ubuntu Description: Ubuntu 18.04.6 LTS Release: 18.04 Codename: bionic


For Artefactual use:

Before you close this issue, you must check off the following:

replaceafill commented 3 months ago

This is still present in https://github.com/artefactual/archivematica/commit/d28909e147704150ce41a268671b55953aa3510e. It can be reproduced with the TestTransfers/manualNormalization sample transfer using the automated processing configuration,