Feature: Allow to run multiple MCPClients with the same configuration

scollazo commented 4 weeks ago

Expected behaviour

I would like to be able to run more than one mcp-client, using the exact same configuration

Current behaviour

Due to the /metrics endpoint being always enabled, different MCPClients need a different value for the ARCHIVEMATICA_MCPCLIENT_MCPCLIENT_PROMETHEUS_BIND_PORT to avoid conflicts with the port.

Steps to reproduce

Run more than one mcpclient with the same settings. They'll conflict due to the prometheus bind port

Your environment (version of Archivematica, operating system, other relevant details)

Archivematica 1.16

For Artefactual use:

Before you close this issue, you must check off the following:

[ ] All pull requests related to this issue are properly linked
[ ] All pull requests related to this issue have been merged
[ ] A testing plan for this issue has been implemented and passed (testing plan information should be included in the issue body or comments)
[ ] Documentation regarding this issue has been written and merged (if applicable)
[ ] Details about this issue have been added to the release notes (if applicable)

scollazo commented 4 weeks ago

One option could be to don't start prometheus server when the port is set to 0

scollazo commented 4 weeks ago

I've been reading it all wrong, is the bind_ip the one that doesn't matter if it's set or not, unsetting bind_port will stop prometheus from conflicting

archivematica / Issues

Feature: Allow to run multiple MCPClients with the same configuration #1698