Problem: createtransfers.py script does not check for existence of existing sample zips

Expected behaviour

When the sample zip files are created, the existing ones should be overwritten so the data produced by the script is always up to date. When the new zips are overwritten the previous zip files should not also be wrapped in the new zip.

Current behaviour

Each time we run the script with an existing set of files already available, the previous set gets wrapped in the new zip. See this output from zipinfo as an example:

zipinfo windows_1252.zip 
Archive:  windows_1252.zip
Zip file size: 1724 bytes, number of entries: 4
drwxrwxr-x  2.0 unx        0 b- stor 18-Sep-26 15:52 windows_1252/
drwxrwxr-x  2.0 unx        0 b- stor 18-Sep-26 15:52 windows_1252/søster/
-rw-rw-r--  2.0 unx     1408 b- defN 18-Sep-25 12:28 windows_1252/windows_1252.zip
-rw-rw-r--  2.0 unx       98 b- defN 18-Sep-26 15:52 windows_1252/søster/cp1252_encoded_dirs.txt
4 files, 1506 bytes uncompressed, 1184 bytes compressed:  21.4%

Steps to reproduce

Run the makefile to produce simple transfers twice and observe the contents of the zip files created. (This only seems to affect the zip files created for variously-encoded-directories)

For Artefactual use: Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

All PRs related to this issue are properly linked 👍
All PRs related to this issue have been merged 👍
Test plan for this issue has been implemented and passed 👍
Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍

archivematica / Issues

Problem: createtransfers.py script does not check for existence of existing sample zips #268