Problem: Preview pane is truncated

archivematica / Issues

Issues repository for the Archivematica project

GNU Affero General Public License v3.0

16 stars 1 forks source link

Problem: Preview pane is truncated #533

Open evelynPM opened 5 years ago

evelynPM commented 5 years ago

Expected behaviour The preview pane should extend further down the screen

Current behaviour annotation 2019-02-26 131923

Steps to reproduce In the Appraisal tab, search for a transfer in backlog, open the file list and select Preview file

Your environment (version of Archivematica, OS version, etc)

For Artefactual use: Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

All PRs related to this issue are properly linked 👍
All PRs related to this issue have been merged 👍
Test plan for this issue has been implemented and passed 👍
Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍

evelynPM commented 5 years ago

Is this actually a regression? In the user manual Landing_zone.jpg looks like it displays nicely: https://www.archivematica.org/en/docs/archivematica-1.8/user-manual/appraisal/appraisal/#file-list. But here's what it looks like when I view it: screenshot from 2019-02-27 17-28-58

evelynPM commented 5 years ago

Looks like this is a browser-related issue: I checked the feature in Firefox and it works as you would expect - the preview pane can be expanded to show the entire image. The screenshot above is from Chrome.

sallain commented 5 years ago

The screenshot in the docs is 3 years old (see the list of images here) and it's not clear which browser was used for the screenshot. As a Chrome user, the preview window is working as it always has in my experience. It may need to be optimized for Chrome, which would be an enhancement, but I wouldn't call this a bug/regression.

ross-spencer commented 5 years ago

Ah, I didn't see a conversation had started here. From Slack, RE: a potential regression, this is a 2018 screenshot I took in Chrome:

https://github.com/artefactual/archivematica/issues/884#issuecomment-372099554

My only instinct as to it not functioning previously was the lack of handle to drag the frame out like in Firefox:

That;s not to say it wouldn't be nice to improve in future.

sevein commented 5 years ago

I've tried removing the iframe and the results are pretty good. We'd be losing the ability to fit/shrink in Firefox, but the new approach makes it work in both Firefox and Chrome.

See https://github.com/artefactual/archivematica/commit/fede1e26aac5df4333b51f1edb20479778a08a13.