archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

Problem: Tagging too many files makes the Appraisal tab to crash #615

Open replaceafill opened 5 years ago

replaceafill commented 5 years ago

Expected behaviour

The Add tag to selected files button of the Backlog pane works with any number of selected files.

Current behaviour

Doing the load testing described in https://github.com/archivematica/Issues/issues/549 we found that attempting to tag too many selected files crashes the browser.

Currently this is what's happening:

This might be improved by using the Bulk API in ElasticSearch.

Some noticeable slowness happens when the user clicks and types in the input form field to enter the tag. This may be caused by the Angular model attached to the input field. This model might be unnecessary because its value is only used when the user clicks the Add tag to selected files button and it's reset after the tag has been applied to the files.

Steps to reproduce

Explained in https://github.com/archivematica/Issues/issues/549

Your environment (version of Archivematica, OS version, etc) https://github.com/artefactual-labs/am/commit/1ef43a43ddf21268ccbb223f7ad43025f485875b


For Artefactual use: Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

jraddaoui commented 5 years ago

Good one @replaceafill!

For the future, about the Elasticsearch validation you mention, we didn't have the time to address a few things in the Elasticsearch upgrade. One of them will definitely help with that, see point 8 in #404.