search

archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

Rejecting a new transfer fails when the rejected folder already has a folder with the same name #647

Open andrewjbtw opened 5 years ago

andrewjbtw commented 5 years ago

Expected behaviour Rejecting a new transfer (i.e. before approval) moves the transfer to the rejected folder.

Current behaviour Rejecting a new transfer fails if a transfer with the same name has already been rejected and is still in the rejected folder. The folder for the second rejected transfer remains in place. Subsequent attempts to start a new transfer with the same name get renamed with an "_" and a numbered suffix in order to avoid name conflicts with the transfer still sitting in the transfer start folder.

The underlying issue seems to be the fact that a rejection prior to approval precedes UUID assignment, leaving nothing to disambiguate folder names from subsequent transfer attempts. Rejection after approval does not have this issue.

Steps to reproduce

  1. Start a transfer but do not approve it.
  2. Reject the transfer.
  3. Start another transfer with the same name and do not approve it.
  4. Reject the second transfer.
  5. Start a third transfer with the same name.

Your environment (version of Archivematica, OS version, etc) AM 1.8, AM 1.9, Ubuntu 18.04

For Artefactual use: Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

ross-spencer commented 5 years ago

Thanks for reporting this @andrewjbtw. I think this issue might duplicate https://github.com/artefactual/archivematica/issues/958 but we can keep this one open as it's in the new repository, and closes another in the Archivematica one. (But please do let us know if you spot a difference between the two scenarios).

andrewjbtw commented 5 years ago

Thanks! That does look like the same issue. I didn't think to check the old issues list before reporting it.