archivematica / Issues

Issues repository for the Archivematica project
GNU Affero General Public License v3.0
16 stars 1 forks source link

Problem: "Transcoding to mkv with ffmpeg" command syntax error when file name has parentheses #753

Open uofmsean opened 5 years ago

uofmsean commented 5 years ago

Expected behaviour Normalization command "Transcoding to mkv with ffmpeg" should work for files with parentheses in the file name. Command UUID is 2d991241-e352-4a77-b104-e7e82fb119c4

Current behaviour Bash shell syntax error with the parentheses because ${outputFile} is not properly quoted like ${inputFile}.

Steps to reproduce Start with mp4 file with parentheses in the file name and normalize for preservation. Example file name: UA_9_People_You_Will_Meet_at_the_Library_(unknown_Accession).mp4

Your environment (version of Archivematica, OS version, etc) Archivematica 1.9.1 Red Hat Enterprise Linux Server release 7.6 (Maipo)


For Artefactual use: Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

ablwr commented 5 years ago

Nice catch!

ablwr commented 5 years ago

In general I'd like to update this entire script to be more plain, like the mp4 access creation script, and follow some of the patterns as generally recommended/vetted by expert preservationists: https://amiaopensource.github.io/ffmprovisr/#create_FFV1_mkv

I'll have to see if there's any limitations given the OSes Archivematica work on are using not-the-most-recent FFmpeg. (Xenial/Bionic are something like 3.3, with CentOS dragging, as usual, at 2.8)