search

archiver-appliance / epicsarchiverap

This is an implementation of an archiver for EPICS control systems that aims to archive millions of PVs.
Other
38 stars 37 forks source link

Issue#161 #162

Closed lcaouen closed 1 year ago

lcaouen commented 1 year ago
jacomago commented 1 year ago

You can remove the line from .classpath instead of duplicating the json jar.

I'm not sure why you removed the build folder from .gitignore? Gradle creates all it's temporary files there which should not be added to the git repository.

lcaouen commented 1 year ago

You can remove the line from .classpath instead of duplicating the json jar : in Eclipse I have errors with some test java class if I don't add it in the classpath... Not sure what you want me to do.

I'm not sure why you removed the build folder from .gitignore? : the default build folder is ../ which is not very convenient as it's outside the archiverap root folder. It would be nicer to use a "build" subfolder. That's why I changed the build.xml. However, the Java CI fails because the build subfolder doesn't exist and is not created automatically. I think I'm gonna add a mkdir directive in the build.xml instead of changing the .gitignore

jacomago commented 1 year ago

I made suggested pull pull request for what I meant with "remove the line from .classpath instead of duplicating the json jar"