search

archiver-appliance / epicsarchiverap

This is an implementation of an archiver for EPICS control systems that aims to archive millions of PVs.
Other
38 stars 37 forks source link

Question about two client libraries #194

Closed jembishop closed 2 months ago

jembishop commented 7 months ago

Somewhat confused why there are two libraries https://github.com/slacmshankar/epicsarchiverap_pbrawclient and the client found here https://github.com/slacmshankar/epicsarchiverap/tree/master/src/main/org/epics/archiverappliance/retrieval/client.

Why can't phoebus use the latter library instead?

Thanks, Jem

jembishop commented 7 months ago

I should have probably read more of the code!


/**
 * Client side class for retrieving data from the appliance archiver using the PB over HTTP protocol.
 * This is mostly used by the unit tests where the ability to treat retrieval results as event streams is veru useful.
 * Java clients should use the pbrawclient which is a lightweight implementation of the same.
 * @author mshankar
 *
 */

Seems strange to have two client libraries though, and I was a bit confused why they have very similar interfaces. Could the modularity be provided by creating multiple jars like how Phoebus does?