https://github.com/slacmshankar/epicsarchiverap/issues/202 - Githubissues

archiver-appliance / epicsarchiverap

This is an implementation of an archiver for EPICS control systems that aims to archive millions of PVs.

Other

38 stars 37 forks source link

https://github.com/slacmshankar/epicsarchiverap/issues/202 #203

Closed lcaouen closed 5 months ago

lcaouen commented 5 months ago

Wrong link in mgmt UI @minijackson, here is the solution provided :

added a new optional parameter in the appliance.xml (retrieval_public_host_url)
if retrieval_public_host_url is present, the url is used instead of data_retrieval_url
if data_retrieval_url is set up with localhost and the mgmt ui is called with a local IP (192.168.XXX.XXX) then replace localhost by the IP

jacomago commented 5 months ago

You need to run gradle spotlessApply to fix the formatting problems. I'll work on updating the docs to add this.

jacomago commented 5 months ago

Hmmm, I just had something similar. Essentially origin/master is what spotless checks against, and has to be up to date with slacmchakar/epicsarchiverap.

lcaouen commented 5 months ago

I've run gradlew :spotlessApply but I still have the formatting problem. It's using 4 spaces indentation. Is it correct ? I'm under windows.

jacomago commented 5 months ago

I think you just need to update the branch master in https://github.com/lcaouen/epicsarchiverap/ to be same as slacmshankar/epicsarchiverap. i.e. sync fork

lcaouen commented 5 months ago

Closing PR. See comments in https://github.com/slacmshankar/epicsarchiverap/issues/202