search

archiver-appliance / epicsarchiverap

This is an implementation of an archiver for EPICS control systems that aims to archive millions of PVs.
Other
38 stars 37 forks source link

Update junit4 tests to junit 5 #209

Closed jacomago closed 3 months ago

shroffk commented 3 months ago

Broadly looks good.. Seems like we might have EOL changes ( or it is a formatting which has resulted in a lot of lines of changes )

thelarsjohansson commented 3 months ago

All updated tests run ok.

However, I would appreciate imports like import org.junit.jupiter.api.Assertions.assertTrue; instead of import org.junit.jupiter.api.Assertions. This makes test appear more clear and easy to read, e.g. assertTrue(pb1DbrTimeEvent.hasFieldValues(), "Adding 1 field value does not turn hasFieldValues on "); instead of Assertions.assertTrue(pb1DbrTimeEvent.hasFieldValues(), "Adding 1 field value does not turn hasFieldValues on ");

( opinions but not blocking commit )

Otherwise, it's fine. But it would be good if less rows were changed for changes like these.