search

archiver-appliance / epicsarchiverap

This is an implementation of an archiver for EPICS control systems that aims to archive millions of PVs.
Other
38 stars 37 forks source link

Introduce end-of-line normalization #220

Closed jacomago closed 3 months ago

nikitakuklev commented 3 months ago

Was it really necessary to 'fix' this and touch every file (111k lines!)? This messes up git blame (unless using -w) and breaks rebase of all custom patches (i.e. I had a few for ANL version)

Please carefully consider the consequences of such changes. I would maybe even roll back to preserve history? @slacmshankar

shroffk commented 3 months ago

EOL changes are always a pain to fix once the project is in full swing.

breaks rebase of all custom patches (i.e. I had a few for ANL version)

Oh, Can you give some details on this... we should try in create and include some checks to ensure we don't break things as we move forward

jacomago commented 3 months ago

Yes, @nikitakuklev Is it possible to upstream some of these changes?