search

archiverjs / node-archiver

a streaming interface for archive generation
https://www.archiverjs.com
MIT License
2.81k stars 220 forks source link

Archiver Version 7.0 might be breaking due to ESM #744

Closed robence closed 6 months ago

robence commented 7 months ago

https://github.com/archiverjs/node-archiver/compare/6.0.2...7.0.0

package lock includes strip-ansi in dependencies both 6.0.1 and 7.1.0

strip ansi v7.0.0 is breaking, contains pure ESM https://github.com/chalk/strip-ansi/releases/tag/v7.0.0

ctalkington commented 6 months ago

it seems the glob update includes jackspeak which relies on cliui which uses newer strip-ansi. I suspect this dependency is for the glob package CLI shouldn't impact archiver and CI runs represent no issues.

If you find otherwise, please post back and I'll see what options we have

note: there's some apparent shimming going on if you notice the -cjs dependencies cliui also uses so I think they did some back compat of their own