search

archivesspace / archivesspace

ArchivesSpace, the archives management tool
http://archivesspace.org/
Other
348 stars 226 forks source link

strip_tags in actionview-5.0.1 causing ActionView error #1327

Closed daveyvango closed 5 years ago

daveyvango commented 6 years ago

Setup:

Symptoms / Problem: For the 8080/staff instance, it seems that strip_tags inside of views/shared/_breadchrumb.html.erb is causing a 500 error with We're sorry, but something went wrong in the browser and logs/archivesspace.log reporting: 

I, [2018-08-07T15:53:38.758079 #12577]  INFO -- :   Rendering events/index.html.erb within layouts/application
I, [2018-08-07T15:53:41.508764 #12577]  INFO -- :   Rendered shared/_breadcrumb.html.erb (278.0ms)
I, [2018-08-07T15:53:41.510137 #12577]  INFO -- :   Rendered events/index.html.erb within layouts/application (2751.4ms)
I, [2018-08-07T15:53:41.512857 #12577]  INFO -- : Completed 500 Internal Server Error in 3709ms
F, [2018-08-07T15:53:41.599798 #12577] FATAL -- :
F, [2018-08-07T15:53:41.600282 #12577] FATAL -- : ActionView::Template::Error (No default implementation found ):

Scope: This is only happening within the staff interface on port 8080. It happens when trying to browse many user pages such as "Events" or "Accessions". It also happens with admin pages like "Manage Repositories" or "Manage Users"

Workaround: Because what's getting sanitized are view names like "Events" and "Accessions", I removed strip_tags from around the crumbs inside of views/shared/_breadcrumb.html.erb of the exploded web app. This cleared out the error and brought leaves the app working just fine.

Question: Has anyone else experienced this? Is this a bug or am I perhaps missing some underlying Ruby gem or something? Is there a better solution to resolve this issue?

Thanks! -Dave

lmcglohon commented 5 years ago

@daveyvango I have been unable to replicate this issue in the latest release so I am going to close this issue. There was a problem when an & was in the breadcrumb which was fixed in https://github.com/archivesspace/archivesspace/pull/1564. If you believe it is still not fixed, please reopen this issue.