search

archivesunleashed / auk-notebooks

Jupyter notebooks to assist in creating additional analysis and visualizations of Archives Unleashed Cloud derivatives.
https://cloud.archivesunleashed.org
Other
11 stars 5 forks source link

Remove ggplot #12

Closed ruebot closed 5 years ago

ruebot commented 5 years ago

DO NOT MERGE UNTIL AFTER #11 IS MERGED

Tested on default dataset and mounted data, all cells worked.

ruebot commented 5 years ago

I tweaked the README, and made sure the auk-example-notebook was fully executed. Added it to this PR since the other two open ones are previous to this one; don't want to end up with merge conflicts :scream:

ruebot commented 5 years ago

Even more fun, it all works with Binder when we add the Dockerfile :tada:

(tweak the User Configuration settings, and run all again)

ruebot commented 5 years ago

...once everything is merged, we can add the badge to the example notebook.

Binder

greebie commented 5 years ago

lgtm once conflicts are resolved.

ruebot commented 5 years ago

@greebie please wait until @ianmilligan1 reviews and tests as well. I'v configured this repo to have at least two reviewers review before a PR is merged now.

ruebot commented 5 years ago

Commit message, when time to merge should read:

Title: Remove ggplot, and have auk-notebook-example fully executed. (#12) Body: 

- Remove ggplot
- Set auk-notebook-example to be fully executed
- Additional README tweaks

screenshot from 2019-03-03 16-17-06

greebie commented 5 years ago

Works good for me too.