search

archivesunleashed / auk-notebooks

Jupyter notebooks to assist in creating additional analysis and visualizations of Archives Unleashed Cloud derivatives.
https://cloud.archivesunleashed.org
Other
11 stars 5 forks source link

Use NLTK stopwords, cite example dataset. #15

Closed ruebot closed 5 years ago

ruebot commented 5 years ago

DO NOT MERGE UNTIL #12 is merged.

- Resolve #14
- Resolve #13
- Update notebooks to use NLTK stopwords
- Add NLTK stopwords
ruebot commented 5 years ago

Binder

ruebot commented 5 years ago

Since we have some discussion going on #13, we'll need to make sure we don't mark it as resolved in the commit message. Just partially addressed, since we're actually citing it now.

ruebot commented 5 years ago

Commit message:

Title: Use NLTK stopwords, update README (#15)

Body:

    - Resolve #14
    - Partially address #13
    - Resolve #17 
    - Update notebooks to use NLTK stopwords
    - Add NLTK stopwords

screenshot from 2019-03-03 21-56-01

greebie commented 5 years ago

Works great. One reminder is that if someone has a notebook up, the docker instructions may not show the correct output. Something to consider for the README.md.

ruebot commented 5 years ago

@ianmilligan1 once dockercloud finishes, this should be good to merge with the commit message above.

Once that's done, I'm jump on some of the other open issues.