Create user variables for easier output.

archivesunleashed / auk-notebooks

Jupyter notebooks to assist in creating additional analysis and visualizations of Archives Unleashed Cloud derivatives.

https://cloud.archivesunleashed.org

Other

11 stars 5 forks source link

Create user variables for easier output. #30

Closed greebie closed 5 years ago

greebie commented 5 years ago

I pulled out the user variables to make changing the visualization both a little more flexible and easier to see.

Some conventions:

I used namespaces DOMAIN, TEXT, OVERALL and NETWORK
In some cases I used an override DOMAIN_ if (DOMAIN_) else CONFIG_
user vars should follow the CAPS_PLUS_UNDERSCORE format.

In some cases, additional descriptions were added to show what's going on a bit better.

greebie commented 5 years ago

Made the changes in docker and they did not carry over. Going to have to redo it. :(

ruebot commented 5 years ago

@greebie Docker is READ ONLY unless you setup your filesystem mount so that it isn't. Best to do the edits locally.

greebie commented 5 years ago

Thanks, yeah - I got lazy because I didn't have nltk.stopwords installed. I managed to port my work over from the read only version, fortunately.

I thought I could get away with trying to download the file, but no go.

ianmilligan1 commented 5 years ago

Let me know when you're ready for me to review again @greebie! Looking forward to checking it out.

greebie commented 5 years ago

One more tiny fix that I missed and we are good to go.

greebie commented 5 years ago

I did a weird thing with OUTPUT_FILENAME. I set it so that filename is TEXT_OUTPUT_FILENAME if that is set, otherwise it uses OUTPUT_FILENAME. Next commit will fix periods etc.

ruebot commented 5 years ago

@greebie can you update the branch too?