Fix malformed JSON for collection ID

archivesunleashed / auk-notebooks

Jupyter notebooks to assist in creating additional analysis and visualizations of Archives Unleashed Cloud derivatives.

https://cloud.archivesunleashed.org

Other

11 stars 5 forks source link

Fix malformed JSON for collection ID #31

Closed ianmilligan1 closed 5 years ago

ianmilligan1 commented 5 years ago

@SamFritz and I were doing some local testing on master and got the following error (on both of our systems):

Somewhere along the line when the collection ID was added in, an escape went mixing which threw off the full cell. This branch works on both of our systems now.

I'm not sure how this happened as it was definitely working locally earlier.

@greebie is currently working on a branch though. So maybe you just want to make sure that it works, so this is more just to have a branch that works (I have it at draft right now).

ruebot commented 5 years ago

My bad.

ruebot commented 5 years ago

Let's get this one in now. It's an easy change for @greebie to pull into his work.

ianmilligan1 commented 5 years ago

Ok I have marked this as ready for review. @greebie can you review + merge?

ianmilligan1 commented 5 years ago

Or actually, I guess @SamFritz can review too since she was in the room and verified that this works! 😄

SamFritz commented 5 years ago

I recloned the repo so I'll be able to do a walk through with a fresh slate. Will let you know if anything seems amiss.

ruebot commented 5 years ago

Let's get #30 finished then.

greebie commented 5 years ago

Almost there. Just fixing a few tiny bugs and we should be good to go in the next commit..

SamFritz commented 5 years ago

this now works for me!