Closed greebie closed 5 years ago
Marked this draft for general comments first. Once the approach is okay, I'll mark it ready for review and we can work through some of the details.
I think the latest commit fixes the above review fixes. I also included mention that help(nb.function_name()) will provide instructions. Once I get word from @ianmilligan1 that the approach is okay, I will take this out of draft and work on fine tuning.
Thanks @ianmilligan1 @ruebot what are your thoughts on unit tests here? I can build them, but am not sure if they belong in the auk-notebooks folder.
Out of scope for now. We'll cross that bridge when we publish it in it's own repo.
Latest commit should be ready to go. Moving this out of draft.
This PR replaces the function cell in the notebook with a python module and revises the function to work with the Notebook class.
A few notes:
fun(x, min_length="2")
- now it just uses the MINIMUM_WORD_LENGTH variable, so