archivesunleashed / auk

Rails application for the Archives Unleashed Cloud.

https://cloud.archivesunleashed.org/

Other

11 stars 4 forks source link

Removing notebook links, discussion; resolves #449 #451

Closed ianmilligan1 closed 3 years ago

ianmilligan1 commented 3 years ago

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

What does this Pull Request do?

This removes the discussion of now deprecated legacy notebooks. I have removed the link from the documentation and from the derivatives learning guide landing page. I kept the notebook lesson itself, in case somebody stumbled on it, but added a deprecation warning.

This was in response to somebody going down the rabbit hole of our notebooks and getting a bit confused - we should have probably ripped this out earlier (I think I'd actually thought that during our March datathon and then never followed up; apologies).

How should this be tested?

The repository should build.

Additional Notes:

Happy holidays! It goes without saying that this is not a time sensitive PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #451 (c0c8429) into main (8031f6b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          35       35           
  Lines         633      633           
=======================================
  Hits          559      559           
  Misses         74       74

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8031f6b...c0c8429. Read the comment docs.