search

archivesunleashed / graphpass

GraphPass is a utility to filter networks and provide a default visualization output for Gephi or SigmaJS.
https://archivesunleashed.org/
Other
17 stars 2 forks source link

Commented out code in gexf.c #28

Closed ruebot closed 6 years ago

ruebot commented 6 years ago

There are a couple chunks of commented out code in src/gexf.c. Are they required, or can they be removed?

greebie commented 6 years ago

The commented out code is to support building into Igraph. Igraph requires graph level attributes (eg. "totalNodes") to accept a PR, but the Gexf (even the 1.3) does not support graph-level attributes.

Since the schema for gexf is not rigidly enforced, it can be uncommented or removed without causing too much trouble.

The potential benefit to auk is if you would like to include some summary information in a sigma graph. For example, if you wanted to have some network summary information included in the visualisation.

In reality, I do not think it is high priority. I will fork the repo from HEAD and keep the leftover code there.

ruebot commented 6 years ago

Sounds like it should be in a feature branch, and worked on there. Once it is ready, it can be pulled in the master.

greebie commented 6 years ago

That sounds like a good idea. I'll set one up.

ruebot commented 6 years ago

New branch here: https://github.com/archivesunleashed/graphpass/tree/issue-34

greebie commented 6 years ago

Resolved with #44 .