archivesunleashed / graphpass

GraphPass is a utility to filter networks and provide a default visualization output for Gephi or SigmaJS.
https://archivesunleashed.org/
Other
17 stars 2 forks source link

Create coverage reports; resolve #58. #59

Closed ruebot closed 6 years ago

ruebot commented 6 years ago

GitHub issue(s): #58

What does this Pull Request do?

How should this be tested?

TravisCI should pass, and CodeCov should be triggered.

Additional Notes:

I'm not 100% happy with all the files that are generated in the root. I'd like to make this better, but first I want to see if this works with CodeCov.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b1f8eec). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   50.13%           
=========================================
  Files             ?        9           
  Lines             ?     1099           
  Branches          ?        0           
=========================================
  Hits              ?      551           
  Misses            ?      548           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1f8eec...b8c4462. Read the comment docs.

ruebot commented 6 years ago

Hey! There we go.

So, we need to decide if we're ok with all the files that are generated in the root when make is run. The extensions are added to .gitignore.

Before:

[nruest@wombat:graphpass] (git)-[issue-58]-$ ls
CODE_OF_CONDUCT.md  CONTRIBUTING.md  doc  Doxyfile  LICENSE.txt  Makefile  README.md  src  vendor

After:

[nruest@wombat:graphpass] (git)-[issue-58]-$ ls
analyze.gcda  CODE_OF_CONDUCT.md  doc       filter.gcda  gexf.gcda  graphpass       graphpass.gcno  io.gcno      Makefile  quickrun.gcda  README.md     reports.gcno  rnd.gcno  vendor    viz.gcno
analyze.gcno  CONTRIBUTING.md     Doxyfile  filter.gcno  gexf.gcno  graphpass.gcda  io.gcda         LICENSE.txt  OUT       quickrun.gcno  reports.gcda  rnd.gcda      src       viz.gcda
greebie commented 6 years ago

This is amazing! Thank you so much. If codecov uses gcov, I think its possible to put the gcdas in a different folder using -fprofile-dir {DIRECTORY}. Not sure if that can work for codecov though.

(reference:here)

ruebot commented 6 years ago

We'd still have the gcno files, which gcov needs.

greebie commented 6 years ago

Just added the extra files for removal using make clean.

Not sure if cleaning helps with codecov, but at least someone can run it if they do not like the extra files.

greebie commented 6 years ago

Do we need to merge this to see the proper reports? Did you want a merge to check? Based on what I see so far, we should be okay to do that. Neither Ian nor I care too much about the extra files and now that we have a clean, it should be fine.

ruebot commented 6 years ago

Please don't push to a pull request I'm working on.