archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.20.0 #230

Closed depfu[bot] closed 3 years ago

depfu[bot] commented 3 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.19.0 → ~> 1.20.0) · Repo · Changelog

Release Notes

1.20.0

New features

  • #10040: Make Lint/Debugger aware of debug.rb. (@koic)
  • #9580: Add a new cop that enforces which bundler gem file to use. (@gregfletch)

Bug fixes

  • #10033: Fix an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chanin. (@koic)
  • #6630: Updated Style/CommentAnnotation to be able to handle multiword keyword phrases. (@dvandersluis)
  • #7836: Update Style/BlockDelimeters to add begin...end when converting a block containing rescue or ensure to braces. (@dvandersluis)
  • #10031: Fix a false positive for Style/HashExcept when comparing with hash value. (@koic)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 3 years ago

Codecov Report

Merging #230 (dce739f) into main (ff3178e) will decrease coverage by 12.12%. The diff coverage is n/a.

:exclamation: Current head dce739f differs from pull request most recent head 3964311. Consider uploading reports for the commit 3964311 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##              main     #230       +/-   ##
============================================
- Coverage   100.00%   87.87%   -12.13%     
============================================
  Files            5        5               
  Lines           33       33               
============================================
- Hits            33       29        -4     
- Misses           0        4        +4     
Impacted Files Coverage Δ
app/models/concerns/warclight/solr_document.rb 71.42% <0.00%> (-28.58%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff3178e...3964311. Read the comment docs.

depfu[bot] commented 3 years ago

Closed in favor of #231.