archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.21.0 #231

Closed depfu[bot] closed 3 years ago

depfu[bot] commented 3 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.19.0 → ~> 1.21.0) · Repo · Changelog

Release Notes

1.21.0

New features

  • #7849: Add new Lint/AmbiguousOperatorPrecedence cop. (@dvandersluis)
  • #9061: Add new Lint/IncompatibleIoSelectWithFiberScheduler cop. (@koic)

Bug fixes

  • #10067: Fix an error for Lint/NumberConversion when using nested number conversion methods. (@koic)
  • #10054: Fix a false positive for Layout/SpaceAroundOperators when match operators between << and +=. (@koic)
  • #10061: Fix a false positive for Style/RedundantSort when using size method in the block. (@koic)
  • #10063: Fix a false positive for Layout/SingleLineBlockChain when method call chained on a new line after a single line block with trailing dot. (@koic)
  • #10064: Fix Style/ExplicitBlockArgument corrector assuming any existing block argument was named block. (@byroot)
  • #10070: Fix a false positive for Style/MutableConstant when using non-interpolated heredoc in Ruby 3.0. (@koic)

Changes

  • #9674: Disable Style/AsciiComments by default. (@dvandersluis)
  • #10051: Improve the messaging for Style/Documentation to be more clear about what class/module needs documentation. (@dvandersluis)
  • #10074: Update Naming/InclusiveLanguage to be disabled by default. (@dvandersluis)
  • #10068: Mark Style/AndOr as unsafe auto-correction. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 27 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 3 years ago

Codecov Report

Merging #231 (6cbae85) into main (ff3178e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff3178e...6cbae85. Read the comment docs.