archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.24.1 #249

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.22.0 → ~> 1.24.1) · Repo · Changelog

Release Notes

1.24.1

Bug fixes

  • #10313: Fix autocorrect Style/MapToHash with multiline code. (@tejasbubane)
  • #10251: Fix an incorrect autocorrect for Gemspec/RequireMFA when .gemspec file contains metadata keys assignments. (@fatkodima)
  • #10329: Fix a false positive for Lint/ParenthesesAsGroupedExpression and an incorrect autocorrect for the cop with Style/TernaryParentheses when using ternary expression as a first argument. (@koic)
  • #10317: Fix a false positive for Style/MethodCallWithArgsParentheses when using hash value omission. (@koic)
  • #10333: Fix an incorrect autocorrect for Naming/BlockForwarding using explicit block forwarding without method definition parentheses. (@koic)
  • #10321: Make Style/MethodDefParentheses aware of Ruby 3.1's anonymous block forwarding. (@koic)
  • #10320: Fix an incorrect autocorrect for Style/FileWrite when using heredoc argument. (@koic)
  • #10319: Require rubocop-ast 1.15.1 to fix a false positive for Style/CombinableLoop when the same method with different arguments and safe navigation. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 2 years ago

Closed in favor of #253.