search

archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.25.1 #256

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.22.0 → ~> 1.25.1) · Repo · Changelog

Release Notes

1.25.1

Bug fixes

  • #10359: Fix a false positive and negative for Style/HashSyntax when using hash value omission. (@koic)
  • #10387: Fix an error for Style/RedundantBegin when assigning nested begin blocks. (@koic)
  • #10366: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and using hash value omission with modifier from. (@koic)
  • #10376: Fix an error for Layout/RescueEnsureAlignment when using .() call with block. (@koic)
  • #10364: Fix an infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. (@koic)
  • #10371: Fix a false negative for Style/HashSyntax when Hash[foo: foo] or {foo: foo} is followed by a next expression. (@koic)
  • #10394: Fix an error for Style/SwapValues when assigning receiver object at def. (@koic)
  • #10379: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when rescue and end are on the same line. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
ruebot commented 2 years ago

@depfu rebase

codecov[bot] commented 2 years ago

Codecov Report

Merging #256 (ceb0a3d) into main (9973305) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #256   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9973305...ceb0a3d. Read the comment docs.