search

archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

Fix docker support #258

Closed obrienben closed 2 years ago

obrienben commented 2 years ago

Docker image was failing to build. Base image of Alpine Ruby needed rolling back to 3.11 and also explicitly set Rails to install v5.2.6. Building with v6 of Rails was causing errors with some of its dependencies.

Also I haven't been able to resolve a particular deprecation warning that occurs throughout building the image. DEPRECATION WARNING: This manually engine loading is deprecated and will be removed in v3.0.0. Removerequire "view_component/engine". (called from <main> at /usr/local/bundle/bundler/gems/warclight-ebf448c0793f/lib/warclight/engine.rb:3) @ruebot any ideas what might fix that warning?

ruebot commented 2 years ago

@obrienben let me take a look. The Ruby 3+ support has been pretty brittle for a while, and I haven't dug into it deeply yet.

ruebot commented 2 years ago

@obrienben I'm not too concerned about that warning since I haven't done any work to officially support Ruby 3+, and Rails 7/8+. I had added it the test matrix for GitHub Actions, and it got to be a nuisance as you might have noticed with this PR. So, I removed it for now. Further, I know upstream Blacklight has support for it, and it just might work here, but I'm not 100% sure and not sure if I'm ever going to really have the time to work on it. My time on this particular AU project (warclight) ended back in 2020 when the first grant wrapped up.