archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.30.0 #276

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.29.0 → ~> 1.30.0) · Repo · Changelog

Release Notes

1.30.0

New features

  • #10065: Add new Gemspec/DeprecatedAttributeAssignment cop. (@koic)
  • #10608: Add new Style/MapCompactWithConditionalBlock cop. (@nobuyo)
  • #10627: Add command-line option --ignore-unrecognized-cops to ignore any unknown cops or departments in .rubocop.yml. (@nobuyo)
  • #10620: Add Sorbet's typed sigil as a magic comment. (@zachahn)

Bug fixes

  • #10662: Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1. (@koic)
  • #10396: Fix autocorrect for Layout/IndentationWidth to leave module/class body unchanged to avoid infinite autocorrect loop with Layout/IndentationConsistency when body trails after class/module definition. (@johnny-miyake)
  • #10636: Fix false positive in Style/RedundantCondition when the branches call the same method on different receivers. (@dvandersluis)
  • #10651: Fix autocorrect for Style/For when using array with operator methods as collection. (@nobuyo)
  • #10629: Fix default Ruby version from 2.5 to 2.6. (@koic)
  • #10661: Fix a false negative for Style/SymbolProc when method has no arguments and AllowMethodsWithArguments: true. (@koic)
  • #10631: Fix autocorrect for Style/RedundantBegin. (@johnny-miyake)
  • #10652: Fix a false positive for Style/FetchEnvVar in conditions. (@ydah)
  • #10665: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. (@koic)
  • #10258: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. (@koic)
  • #10668: Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0. (@koic)
  • #10644: Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2. (@koic)
  • #10639: Fix Style/HashSyntax to exclude files that violate it with EnforceHashShorthandSyntax when running auto-gen-config. (@nobuyo)
  • #10633: Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor. (@dvandersluis)
  • #10618: Fix LineBreakCorrector so that it won't remove a semicolon in the class/module body. (@johnny-miyake)
  • #10646: Fix an incorrect autocorrect for Style/SoleNestedConditional when using unless and && without parens in the outer condition and nested modifier condition. (@koic)
  • #10659: Fix automatically appended path for inherit_from by auto-gen-config is incorrect if specified config file in a subdirectory as an option. (@nobuyo)
  • #10640: Recover Ruby 2.3 code analysis using TargetRubyVersion: 2.3. (@koic)
  • #10657: Fix --auto-gen-config command option ignores specified config file by option. (@nobuyo)

Changes

  • #10095: Change "auto-correct" to "autocorrect" in arguments, documentation, messages, comments, and specs. (@chris-hewitt)
  • #10656: Mark Style/RedundantInterpolation as unsafe autocorrection. (@koic)
  • #10616: Markdown formatter: skip files with no offenses. (@rickselby)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 54 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 2 years ago

Closed in favor of #278.