archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.31.0 #284

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.30.1 → ~> 1.31.0) · Repo · Changelog

Release Notes

1.31.0

New features

  • #10699: Add new global ActiveSupportExtensionsEnabled option. (@nobuyo)
  • #10245: Add specification_version and rubygems_version to Gemspec/DeprecatedAttributeAssignment. (@kaitielth)
  • #10696: Add new Lint/NonAtomicFileOperation cop. (@ydah)
  • #6420: Add new Layout/LineContinuationLeadingSpace cop. (@bquorning)
  • #6420: Add new Layout/LineContinuationSpacing cop. (@bquorning)
  • #10706: Integrate rubocop-daemon to add server options. (@koic)
  • #10722: Add new Lint/ConstantOverwrittenInRescue cop. (@ydah)

Bug fixes

  • #10700: Update Style/EmptyMethod to not correct if the correction would exceed the configuration for Layout/LineLength. (@dvandersluis)
  • #10698: Enhance Style/HashExcept to support array inclusion checks. (@nobuyo)
  • #10734: Handle ClobberingError in Style/NestedTernaryOperator when there are multiple nested ternaries. (@dvandersluis)
  • #10689: Fix autocorrect for Layout/FirstHashElementIndentation and Layout/FirstArrayElementIndentation. (@j-miyake)
  • Fix rubocop -V not displaying the version information for rubocop-graphql, rubocop-md and rubocop-thread_safety. (@Darhazer)
  • #10711: Fix an error for Style/MultilineTernaryOperator when the false branch is on a separate line. (@koic)
  • #10719: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using safe navigation operator. (@koic)
  • #10736: Fix Layout/SpaceInsideBlockBraces for blocks with numbered arguments. (@gsamokovarov)
  • #10749: Fix Style/BlockDelimiters for blocks with numbered arguments. (@gsamokovarov)
  • #10737: Fix crash in Style/ConditionalAssignment with EnforcedStyle: assign_inside_condition when op-assigning a variable inside a resbody. (@dvandersluis)
  • #7900: Fix Style/FormatStringToken false positive with formatted input and template style enforced, and add autocorrection. (@FnControlOption)

Changes

  • #10730: Change output timing of GitHubActionsFormatter. (@r7kamura)
  • #10709: Deprecate rubocop:auto_correct custom rake task and newly split rubocop:autocorrect and rubocop:autocorrect-all custom rake tasks. (@koic)
  • #9760: Change RangeHelp#range_with_surrounding_space to allow passing the range as a positional argument. (@pirj)
  • #10693: Add ignore case for Style/EmptyLinesAroundAttributeAccessor when there is a comment line on the next line. (@ydah)
  • #10245: (Breaking) integrate Gemspec/DateAssignment into Gemspec/DeprecatedAttributeAssignment. (@kaitielth)
  • #10697: Restore Lint/UselessElseWithoutRescue cop. (@koic)
  • #10740: Make Style/GuardClause a bit more lenient when the replacement would make the code more verbose. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 2 years ago

Codecov Report

Merging #284 (de15fff) into main (111cb7c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #284   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 111cb7c...de15fff. Read the comment docs.

depfu[bot] commented 2 years ago

Closed in favor of #286.