archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.35.1 #300

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.32.0 → ~> 1.35.1) · Repo · Changelog

Release Notes

1.35.1

Bug fixes

  • #10926: Make Style/SafeNavigation aware of a redundant nil check. (@koic)
  • #10944: Fix an incorrect autocorrect for Lint/LiteralInInterpolation when using "#{nil}". (@koic)
  • #10921: Fix an error when ERB pre-processing of the configuration file. (@koic)
  • #10936: Fix an error for Lint/NonAtomicFileOperation when using FileTest.exist? as a condition for elsif. (@koic)
  • #10920: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested conditional and branch contains a comment. (@koic)
  • #10939: Fix an error for Style/Next when line break before condition. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 2 years ago

Codecov Report

Merging #300 (001e89a) into main (fb66045) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.