archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.36.0 #302

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.35.1 → ~> 1.36.0) · Repo · Changelog

Release Notes

1.36.0

New features

Bug fixes

  • #10958: Fix an infinite loop for Layout/SpaceInsideBlockBraces when EnforcedStyle is no_space and using multiline block. (@ydah)
  • #10903: Skip forking off extra processes for parallel inspection when only a single file needs to be inspected. (@wjwh)
  • #10919: Fix a huge performance regression between 1.32.0 and 1.33.0. (@ydah)
  • #10951: Fix an autocorrection error for Lint/EmptyConditionalBody when some conditional branch is empty. (@ydah)
  • #10927: Fix a false positive for Style/HashTransformKeys and Style/HashTransformValues when not using transformed block argument. (@koic)
  • #10979: Fix a false positive for Style/RedundantParentheses when using parentheses with pin operator except for variables. (@Tietew)
  • #10962: Fix a false positive for Lint/ShadowingOuterLocalVariable when conditional with if/elsif/else branches. (@ydah)
  • #10969: Fix a false negative for AllowedPatterns of Lint/AmbiguousBlockAssociation when using a method chain. (@jcalvert)
  • #10963: Fix a false positive for Layout/IndentationWidth when using aligned empty else in pattern matching. (@koic)
  • #10975: Fix possible wrong autocorrection in namespace on Style/PerlBackrefs. (@r7kamura)

Changes

  • #10928: Add more autocorrect support on Style/EachForSimpleLoop. (@r7kamura)
  • #10960: Add as to AllowedNames in default configuration for Naming/MethodParameterName cop. (@koic)
  • #10966: Add autocorrect support to Style/AccessModifierDeclarations. (@r7kamura)
  • #10940: Add server mode status to -V option. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 49 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 2 years ago

Codecov Report

Merging #302 (b31600b) into main (11d4ead) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

depfu[bot] commented 2 years ago

Closed in favor of #306.