search

archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.37.0 #306

Closed depfu[bot] closed 2 years ago

depfu[bot] commented 2 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.35.1 → ~> 1.37.0) · Repo · Changelog

Release Notes

1.37.0

New features

  • #11043: Add new Lint/DuplicateMagicComment cop. (@koic)
  • #10409: Add --no-exclude-limit CLI option. (@r7kamura)
  • #10986: Add autocorrect for Style/StaticClass. (@FnControlOption)
  • #11018: Add AllowedMethods and AllowedPatterns for Lint/NestedMethodDefinition. (@koic)
  • #11055: Implement Lint/DuplicateMethods for object singleton class. (@tdeo)
  • #10997: Make rubocop command aware of --server option from .rubocop and RUBOCOP_OPTS. (@koic)
  • #11079: Add new Style/OperatorMethodCall cop. (@koic)
  • #10439: Add new Style/RedundantStringEscape cop. (@owst)

Bug fixes

  • #11034: Fix server mode behavior when using --stderr. (@tdeo)
  • #11028: Fix a false positive for Lint/RequireParentheses when using ternary operator in square bracksts. (@koic)
  • #11051: Preserve comments on Style/AccessModifierDeclarations autocorrection. (@r7kamura)
  • #9116: Support super method in Layout/FirstArgumentIndentation. (@tdeo)
  • #11068: Fix a false positive for Style/RedundantRegexpCharacterClass when using starting with "\0" number. (@koic)
  • #11082: Fix an incorrect autocorrect for Lint/SafeNavigationChain when safe navigation on the right-hand side of the arithmetic operator. (@ydah)
  • #10982: Do not autocorrect parentheses for calls in assignments in conditional branches for Style/MethodCallWithArgsParentheses with omit_parentheses. (@gsamokovarov)
  • #11084: Fix an error for Style/ParallelAssignment when using parallel assignment in singleton method. (@koic)
  • #11078: Fix a false positive for Style/RedundantBegin when using endless method definition for begin with multiple statements. (@koic)
  • #11074: Fix a false positive for Lint/RedundantDirGlobSort when using Dir.glob with multiple arguments. (@koic)
  • #11025: Check comments for disables in RedundantInitialize cop. (@HeroProtagonist)
  • #11003: Fix clobbering exception in EmptyConditionalBody cop when if branch is empty but else is not. (@srcoley)
  • #11026: Fix an error occurred for Style/SymbolArray and Style/WordArray when empty percent array. (@ydah)
  • #11022: Fix an incorrect autocorrect for Style/RedundantCondition when using redundant brackets access condition. (@koic)
  • #11037: Fix a false positive for Style/CollectionCompact when using to_enum.reject or lazy.reject methods with Ruby 3.0 or lower. (@koic)
  • #11017: Fix an autocorrect for Lint/EmptyConditionalBody that causes a SyntaxError when missing if and else body. (@ydah)
  • #11047: Fix an incorrect autocorrect for Style/SafeNavigationChain when using +@ and -@ methods. (@koic)
  • #11015: Fix a false positive for Style/HashSyntax when without parentheses call expr follows after nested method call. (@koic)
  • #11067: Fix a false positive for Lint/DuplicateRegexpCharacterClassElement when using regexp character starts with escaped zero number. (@koic)
  • #11030: Fix an incorrect autocorrect for Lint/UnusedMethodArgument and Style::ExplicitBlockArgument when autocorrection conflicts for &block argument. (@koic)
  • #11069: Fix an incorrect autocorrect for Lint/RedundantCopDisableDirective when disable directive contains free comment. (@koic)
  • #11063: Preserve comments on Style/AccessorGrouping autocorrection. (@r7kamura)
  • #10994: Fix an error when running 3rd party gem that does not require server. (@koic)

Changes

  • #11054: Implement correct behavior for compact mode for Layout/SpaceInsideArrayLiteralBrackets. (@tdeo)
  • #10924: Style/NegatedIfElseCondition also checks negative conditions inside parentheses. (@tsugimoto)
  • #11042: Mark Lint/OrderedMagicComments as unsafe autocorrection. (@koic)
  • #11057: Make Lint/RedundantRequireStatement aware of pp, ruby2_keywords, and fiber. (@koic)
  • #10988: Raise error when both safe and unsafe autocorrect options are specified. (@koic)
  • #11032: Detect empty Hash literal braces containing only newlines and spaces on Layout/SpaceInsideHashLiteralBraces. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (a7a8281) compared to base (11d4ead). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 33 33 ========================================= Hits 33 33 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

depfu[bot] commented 2 years ago

Closed in favor of #308.