search

archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.40.0 #314

Closed depfu[bot] closed 1 year ago

depfu[bot] commented 1 year ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.35.1 → ~> 1.40.0) · Repo · Changelog

Release Notes

1.40.0

New features

  • #11179: Add Style/RedundantConstantBase cop. (@r7kamura)
  • #11205: Add --[no-]auto-gen-enforced-style CLI option. (@ydah)
  • #11224: Add Style/RequireOrder cop. (@r7kamura)
  • #11219: Make Style/SelectByRegexp aware of !~ method. (@koic)
  • #11224: Add new cop Style/ArrayIntersect which replaces (array1 & array2).any? with array1.intersect?(array2), method Array#intersect? was added in ruby 3.1. (@KirIgor)
  • #11211: Add autocorrect for Lint/AssignmentInCondition. (@r7kamura)

Bug fixes

  • #5251: Fix loading of configuration in multi-file edge case. (@NobodysNightmare)
  • #11192: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using a block argument. (@ydah)
  • #11143: Fix RedundantCopDisableDirective errors when encountering several department comments. (@isarcasm)
  • #11230: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with [] operator followed by method chain. (@koic)
  • #11181: Fix pattern to match .tool-versions files that specify multiple runtimes. (@noelblaschke)
  • #11239: Fix an incorrect autocorrect for Style/GuardClause when using heredoc as an argument of raise in branch body. (@koic)
  • #11182: Fix an incorrect autocorrect for EnforcedShorthandSyntax: always of Style/HashSyntax with Style/IfUnlessModifier when using Ruby 3.1. (@koic)
  • #11184: Fix an error for Lint/ShadowingOuterLocalVariable when a block local variable has same name as an outer until scope variable. (@koic)
  • #11198: Fix an error for Lint/EmptyConditionalBody when one using line if/;/end without then boby. (@koic)
  • #11196: Fix a false positive for Style/GuardClause when using raise in then body of if..elsif..end form. (@koic)
  • #11213: Support redundant department disable in scope of Lint/RedundantCopDisableDirective cop. (@isarcasm)
  • #11200: Fix an incorrect autocorrect for Layout/MultilineMethodCallBraceLayout when using method chain for heredoc argument in multiline literal brace layout. (@koic)
  • #11190: Fix an error for Style/IfWithSemicolon when using one line if/;/end without then boby. (@koic)
  • #11244: Fix a false negative for Style/RedundantReturn when dynamic define methods. (@ydah)

Changes

  • #11218: Update severity of Bundler/DuplicatedGem, Bundler/InsecureProtocolSource, Gemspec/DeprecatedAttributeAssignment, Gemspec/DuplicatedAssignment, Gemspec/RequireMFA, Gemspec/RequiredRubyVersion, and Gemspec/RubyVersionGlobalsUsage cops to warning. (@koic)
  • #11222: Make Style/RedundantArgument aware of Array#sum. (@koic)
  • #11070: Add ability to count method calls as one line to code length related Metric cops. (@fatkodima)
  • #11226: Make Lint/Void aware of used lambda and proc in void context. (@koic)
  • #11205: Change Lint/InterpolationCheck from Safe: false to SafeAutoCorrect: false. (@r7kamura)
  • #11212: Make Lint/DeprecatedConstants aware of deprecated Struct::Group and Struct::Passwd classes. (@koic)
  • #11236: Remove respond_to from default value of AllowedMethods for Style/SymbolProc. (@koic)
  • #11185: Make Style/HashSyntax aware of without parentheses call expr follows. (@koic)
  • #11203: Support multiple arguments on Lint/SendWithMixinArgument. (@r7kamura)
  • #11229: Add cc to AllowedNames of MethodParameterName cop. (@tjschuck)
  • #11116: Handle ternaries in Style/SafeNavigation. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 69 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (aa1b175) compared to base (11d4ead). Patch has no changes to coverable lines.

:exclamation: Current head aa1b175 differs from pull request most recent head 5158481. Consider uploading reports for the commit 5158481 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #314 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 33 33 ========================================= Hits 33 33 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.