search

archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop-rspec to version 2.15.0 #316

Closed depfu[bot] closed 1 year ago

depfu[bot] commented 1 year ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 2.11.1 → ~> 2.15.0) · Repo · Changelog

Release Notes

2.15.0

  • Fix a false positive for RSpec/RepeatedDescription when different its block expectations are used. (@ydah)
  • Add named_only style to RSpec/NamedSubject. (@kuahyeow)
  • Fix RSpec/FactoryBot/ConsistentParenthesesStyle to ignore calls without the first positional argument. (@pirj)
  • Fix RSpec/FactoryBot/ConsistentParenthesesStyle to ignore calls inside a Hash or an Array. (@pirj)
  • Fix RSpec/NestedGroups to correctly use AllowedGroups config. (@samrjenkins)
  • Remove Runners and HookScopes RSpec DSL elements from configuration. (@pirj)
  • Add with default RSpec/Language config helper to lib (under rubocop/rspec/shared_contexts/default_rspec_language_config_context), to allow use for downstream cops based on RuboCop::Cop::RSpec::Base. (@smcgivern)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 28 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4e1424d) compared to base (a1d2a43). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 33 33 ========================================= Hits 33 33 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.