archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.42.0 #323

Closed depfu[bot] closed 1 year ago

depfu[bot] commented 1 year ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.40.0 → ~> 1.42.0) · Repo · Changelog

Release Notes

1.42.0

New features

Bug fixes

  • #11204: Fix a false negative for Lint/RedundantCopDisableDirective when using --except command line option. (@koic)
  • #11369: Fix an error for Lint/UselessRuby2Keywords when using Proc#ruby2_keywords. (@koic)
  • #11351: Fix an incorrect autocorrect for Lint/RegexpAsCondition when using regexp literal with bang. (@koic)
  • #11329: Accept simple freezed constants in Layout/ClassStructure and correctly handle class methods. (@fatkodima)
  • #11344: Fix an error for Style/GuardClause when using heredoc as an argument of raise in then branch and it does not have else branch. (@koic)
  • #11335: Fix an error for Style/RequireOrder when only one reuqire. (@koic)
  • #11348: Fix an error for Style/SelectByRegexp when block body is empty. (@koic)
  • #11320: Fix a false positive for Lint/RequireParentheses when assigning ternary operator. (@koic)
  • #11361: Make Style/MethodDefParentheses aware of Ruby 3.2's anonymous rest and keyword rest arguments. (@koic)
  • #11346: Fix a false positive for Style/RedundantStringEscape when using escaped space in heredoc. (@koic)
  • #10858: Fix Style/IdenticalConditionalBranches to ignore identical leading lines when branch has single child and is used in return context. (@fatkodima)
  • #11237: Fix Layout/CommentIndentation comment aligned with access modifier indentation when EnforcedStyle is outdent. (@soroktree)
  • #11330: Fix an error for Style/RequireOrder when using require inside rescue body. (@fatkodima)
  • #8751: Accept super within ranges for Layout/SpaceAroundKeyword cop. (@fatkodima)
  • #10194: Accept bracketed arrays within 2d arrays containing subarrays with complex content for Style/WordArray cop. (@fatkodima)

Changes

  • #8366: Ignore private constants in Layout/ClassStructure cop. (@fatkodima)
  • #11325: Support autocorrection for percent literals in Style/ConcatArrayLiterals. (@fatkodima)
  • #11327: Make Style/ZeroLengthPredicate aware of array.length.zero?. (@koic)
  • #10976: Support pattern matching for Lint/OutOfRangeRegexpRef cop. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 51 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 87.87% // Decreases project coverage by -12.12% :warning:

Coverage data is based on head (2125c78) compared to base (26de50f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #323 +/- ## ============================================ - Coverage 100.00% 87.87% -12.13% ============================================ Files 5 5 Lines 33 33 ============================================ - Hits 33 29 -4 - Misses 0 4 +4 ``` | [Impacted Files](https://codecov.io/gh/archivesunleashed/warclight/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed) | Coverage Δ | | |---|---|---| | [app/models/concerns/warclight/solr\_document.rb](https://codecov.io/gh/archivesunleashed/warclight/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed#diff-YXBwL21vZGVscy9jb25jZXJucy93YXJjbGlnaHQvc29scl9kb2N1bWVudC5yYg==) | `71.42% <0.00%> (-28.58%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=archivesunleashed)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

depfu[bot] commented 1 year ago

Closed in favor of #324.