archivesunleashed / warclight

A Rails engine supporting the discovery of web archives.
https://archivesunleashed.org/warclight/
Other
49 stars 10 forks source link

[ruby] Upgrade rubocop to version 1.43.0 #324

Closed depfu[bot] closed 1 year ago

depfu[bot] commented 1 year ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.40.0 → ~> 1.43.0) · Repo · Changelog

Release Notes

1.43.0

New features

Bug fixes

  • #11386: Fix a false positive for Style/OperatorMethodCall when using anonymous forwarding. (@koic)
  • #11409: Fix an incorrect autocorrect for Style/HashSyntax when using hash value omission and EnforcedStyle: no_mixed_keys. (@koic)
  • #11405: Fix undefined method `range_between' for Style/WhileUntilModifier. (@such)
  • #11374: Fix an error for Style/StringHashKeys when using invalid symbol in encoding UTF-8 as keys. (@koic)
  • #11392: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces using double splat in double splat hash braces. (@koic)
  • #8990: Make Style/HashEachMethods aware of built-in Thread.current. (@koic)
  • #11390: Fix an incorrect autocorrect for Style/HashSyntax when hash first argument key and hash value only are the same which has a method call on the next line. (@koic)
  • #11379: Fix a false negative for Style/OperatorMethodCall when using a.+ b.something. (@koic)
  • #11180: Fix an error for Style/RedundantRegexpEscape when using %r to provide regexp expressions. (@si-lens)
  • #11403: Fix bad offense for parenthesised calls in literals for omit_parentheses style in Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #11407: Fix an error for Style/HashSyntax when expression follows hash key assignment. (@fatkodima)
  • #11377: Fix Style/OperatorMethodCall when forwarding arguments. (@sambostock)

Changes

  • #11382: Require unicode-display_width 2.4.0 or higher. (@fatkodima)
  • #11381: Require Parser 3.2.0.0 or higher. (@koic)
  • #11380: Disable Style/YodaExpression by default. (@koic)
  • #11303: Make Metrics/ParameterLists aware of Struct.new and Data.define blocks. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 33 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 1 year ago

Closed in favor of #331.