Fix types for ARMv7 arch

archlinux / alpm.rs

Rust bindings for libalpm

GNU General Public License v3.0

112 stars 21 forks source link

Fix types for ARMv7 arch #2

Closed 0x1793d1 closed 4 years ago

0x1793d1 commented 4 years ago

alpm.rs cannot compile on ARMv7, because on this architecture:

c_ulong is u32
c_long is i32
c_char is u8

0x1793d1 commented 4 years ago

I have just seen that PR #1 tried to fix the problem of the pubkey_algo function. However, I think it's better to change the return of the function for a u8, because otherwise we have to do a self.inner. pubkey_algo.try_into().unwrap () that may panic if pubkey_algo > i8::max_value().

Morganamilo commented 4 years ago

I already noted in #1 that the return type should be u8 so it better matches alpm. Just not done anything on this project since.

On the ARM side, being able to compile is probably a good thing. I don't run any ARM devices though, so I'll trust you to fix the differences.