search

archlinux / arch-security-tracker

Arch Linux Security Tracker
https://security.archlinux.org
MIT License
120 stars 38 forks source link

Fix #197 jinja deprecation issues #201

Closed ysf closed 2 years ago

ysf commented 2 years ago

Fixes the deprecation warnings of jinja2.markup, jinja2.escape and one regex that has not been upgraded to python3.

jelly commented 2 years ago

Looks good to me, I think we need to add an explicit dependency now on markupsafe in our readme, as although jinja depends on it now in the future it might not?

Should be changing the README.md, .github/workflows/test.yml with the new dependency.

ysf commented 2 years ago

Since jinja2 and markupsafe are both from the same project and markupsafe has been refactored from jinja2 to an own package, I think there would be needed to re-do some work around jinja2 and the tracker anyway if jinja2 should somehow remove this dependency. it's extremely unlikely that they'll do that.

that said: I'll add it to the files tomorrow as it won't hurt either.

anthraxx commented 2 years ago

This looks awesome. thank you very much <3

anthraxx commented 2 years ago

@ysf we still need to change .github/workflows/test.yml as well, can you please do that and rebase against latest master?

anthraxx commented 2 years ago

applied via 0effc7403f1440449314529097cb92ad7827e081 thanks a lot