Open Torxed opened 1 year ago
Ruff is a linter with automatic fixes. Autoformatting is a work-in-progress in it and I'm not sure it's available in any released version of Ruff yet.
From your output it should be obvious no formatting was performed.
Ruff is a linter with automatic fixes. Autoformatting is a work-in-progress in it and I'm not sure it's available in any released version of Ruff yet.
From your output it should be obvious no formatting was performed.
Noted from the discussion in the mentioned issue, however I'm intreagued in that development and see where it leads :D
I was happy about the few warnings as well as the cleanup that it did. I'm probably the only one but I appreciate the non-intrusiveness :)
I think ruff is having different goals, at least in the current state, than an actual formatter. It's main purpose seems to be the actual combination of other linters in existence, as far as I can tell it wouldn't even replace mypy but only flake8.
I think the "formatting" you experienced isn't actual formatting but just aligning some things, it would most likely not help giving the code base a uniform format...
The point of intrusiveness at this point is most likely that an initial run will do a lot of changes as the code is very diverse but as it continues after that it would be smaller
In light of https://github.com/charliermarsh/ruff/issues/1904#issuecomment-1470946322 I'm intrigued to evaluate Ruff as a code formatter.
It looks like it could combat some of my quarrels with https://github.com/archlinux/archinstall/pull/997 (Linked with issue https://github.com/archlinux/archinstall/issues/872).
Specifically the sentences:
I ran a super default test and it doesn't appear to be very intrusive. It can also be found in the WIP PR I opened: https://github.com/archlinux/archinstall/pull/1681